rusackas commented on PR #41697: URL: https://github.com/apache/superset/pull/41697#issuecomment-4895843511
Second root cause found and fixed in 897d2f9b86, thanks to the ✨ screenshot: Ace's full-width tables only cover East-Asian ranges. Astral emoji (💡, surrogate pairs) accidentally align because the renderer's surrogate branch forces a 2-cell box and the column counter counts two code units, but BMP emoji like ✨ (U+2728) fall through both nets... one column in the math, ~1.6 cells on screen, and the caret drifts on exactly those lines. Upstream ace has this open as ajaxorg/ace#3404. The fix extends the mechanism ace already uses for CJK to emoji-presentation codepoints and VS16 sequences: two columns in the session math, and the same forced 2×charWidth `.ace_cjk` box in the text layer, so grid and pixels agree. ZWJ families and flag pairs are left out (they need grapheme segmentation across every layer, and were equally misaligned before). Eight new tests, including caret math on the literal `### ✨Header 3` repro line. Title updated to match the wider scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
