rusackas commented on PR #39452: URL: https://github.com/apache/superset/pull/39452#issuecomment-4895949689
Thanks @EnxDev, good pass. The TTestTable recompute-on-data-change and the status-class coercion were intentional fixes riding along with the conversion... both are called out in the PR body now, with regression tests covering the data-shrink clamp and the lift cell classes. Also restored `Infinity` for the zero-sum control case (and fixed the misleading jsdom comment in the test), wrapped `PairedTTest` and `WordCloud` in `memo()` for PureComponent parity, hoisted the conditional `useMemo`, and added render/redraw tests for HorizonChart, HorizonRow, and WordCloud. The PR body notes were against an older revision, I think... the MapBox drop and the `master` base are already in there. Running CI 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
