rusackas opened a new pull request, #41821: URL: https://github.com/apache/superset/pull/41821
### SUMMARY Follow-up to #41697, addressing a fair CodeAnt catch that landed after merge: the emoji width patch appends its forced-width `.ace_cjk` boxes directly to the line, outside the token-class wrapper ace puts around non-text tokens. Emoji glyphs carry their own color so the visible impact is small, but token styling that isn't glyph color — comment italics, `ace_invalid` backgrounds, and any theme's token-level styling — stopped applying to emoji segments inside those tokens. Fix: mirror ace's `text_util.isTextToken` / `$renderToken` class construction directly on the emoji box (`ace_cjk ace_constant ace_language` for a `constant.language` token, bare `ace_cjk` for text tokens). Same cascade as ace's own nesting, no extra DOM. Two new tests pin the class carrying for dotted token types and the bare-text case; `emojiWidthPatch.ts` stays at 100% coverage. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — token-styling fidelity fix; caret behavior unchanged. ### TESTING INSTRUCTIONS ```bash cd superset-frontend && npx jest packages/superset-ui-core/src/components/AsyncAceEditor/emojiWidthPatch.test.ts ``` 13 passed, 100% coverage on the patch module. ### ADDITIONAL INFORMATION - [x] Has associated issue: follow-up to #41697 / #41664 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
