mistercrunch commented on a change in pull request #8410: Add hana
URL: 
https://github.com/apache/incubator-superset/pull/8410#discussion_r336328389
 
 

 ##########
 File path: docs/installation.rst
 ##########
 @@ -402,6 +402,9 @@ Here's a list of some of the recommended packages.
 | Vertica          | ``pip install                         |  
``vertica+vertica_python://``                  |
 |                  | sqlalchemy-vertica-python``           |                   
                              |
 
+------------------+---------------------------------------+-------------------------------------------------+
+| Hana             | ``pip install hdbcli``                |  ``hana://``      
            |
 
 Review comment:
   based on other suggested changes using setuptools' `extras_require`, this 
should be `pip install superset[hana]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to