villebro commented on a change in pull request #8411: Add support for database
engine SAP Hana
URL:
https://github.com/apache/incubator-superset/pull/8411#discussion_r336491924
##########
File path: setup.py
##########
@@ -116,13 +115,14 @@ def get_git_sha():
"postgres": ["psycopg2-binary==2.7.5"],
"presto": ["pyhive[presto]>=0.4.0"],
"druid": ["pydruid==0.5.2", "requests==2.22.0"],
+ "hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"],
},
python_requires="~=3.6",
author="Apache Software Foundation",
author_email="[email protected]",
url="https://superset.apache.org/";,
download_url=(
- "https://dist.apache.org/repos/dist/release/superset/"; + version_string
+ "https://dist.apache.org/repos/dist/release/superset/"; +
version_string
Review comment:
This is over-indented; reverting to the original indentation should be
correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
