john-bodley commented on a change in pull request #8409: [ci] Deprecate flake8
URL:
https://github.com/apache/incubator-superset/pull/8409#discussion_r336620767
##########
File path: superset/connectors/druid/models.py
##########
@@ -137,14 +134,14 @@ class DruidCluster(Model, AuditMixinNullable,
ImportMixin):
broker_user = Column(String(255))
broker_pass = Column(EncryptedType(String(255), conf.get("SECRET_KEY")))
- export_fields = (
+ export_fields = [
"cluster_name",
"broker_host",
"broker_port",
"broker_endpoint",
"cache_timeout",
"broker_user",
- )
+ ]
Review comment:
@villebro I initially though these were defined in FAB but the base class is
[here](https://github.com/apache/incubator-superset/blob/648f9fa54b90ce4cca84737a21214fd92c0e9fcc/superset/models/helpers.py#L55).
`mypy` simply ensures that the types are consistent.
Personally I like having differentiation between `List` and `Tuple` as it
indicates whether the object is mutable or non-mutable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
