gkneighb commented on PR #41472: URL: https://github.com/apache/superset/pull/41472#issuecomment-4899281123
Rebased fallout fixed + one substantive update since the last review window: - **Soft-delete aware**: with #40128/#40129/#41166 now on master, these tools mirror the `BaseDAO.delete` routing predicate and report what actually happened via a new `soft_deleted` response field — "moved to trash, restorable by an owner or Admin" when the `SOFT_DELETE` flag is on, "permanently deleted" otherwise. Tool docstrings and the `app.py` instruction strings updated to match, so LLM clients won't tell users a trashed chart is unrecoverable. - **CI**: the `pre-commit (current)` failure on the previous run was ruff-format drift in `dashboard/schemas.py` from the master merge — fixed in the same commit. 12 unit tests total (4 new covering both routing modes for each tool); full `tests/unit_tests/mcp_service` suite passes locally (2508 tests). Follow-up PR planned for `restore_chart`/`restore_dashboard` wrapping the new restore commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
