rusackas commented on code in PR #41346:
URL: https://github.com/apache/superset/pull/41346#discussion_r3533546531
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/buildQuery.ts:
##########
@@ -378,11 +402,19 @@ const buildQuery: BuildQuery<TableChartFormData> = (
JSON.stringify(options?.extras?.cachedChanges?.[formData.slice_id]) !==
JSON.stringify(queryObject.filters)
) {
- queryObject = { ...queryObject, row_offset: 0 };
+ // Reset to the first page: restore the full first-page row_limit rather
+ // than carrying over the last page's capped value.
+ queryObject = {
+ ...queryObject,
+ row_offset: 0,
+ row_limit: firstPageRowLimit,
Review Comment:
Good catch, that reset was clobbering row_limit on downloads too. Guarded it
with `!isDownloadQuery` and added a test, pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
