anamitraadhikari commented on code in PR #41031:
URL: https://github.com/apache/superset/pull/41031#discussion_r3534300481
##########
superset-frontend/src/components/GridTable/index.tsx:
##########
@@ -138,18 +139,20 @@ export function GridTable<RecordType extends object>({
[columnReorderable, enableActions, sortable],
);
- const rowHeight = theme.sizeUnit * (size === GridSize.Middle ? 9 : 7);
+ const defaultRowHeight = theme.sizeUnit * (size === GridSize.Middle ? 9 : 7);
+ const rowHeight = themeOverrides?.rowHeight ?? defaultRowHeight;
+ const headerHeight = themeOverrides?.headerHeight ?? rowHeight;
Review Comment:
Thanks for flagging this. I checked the existing implementation on master,
and GridTable already sets headerHeight equal to rowHeight, so this fallback
preserves the current behavior rather than introducing a new fixed header
height. The resultsGridRowHeight token is also intentionally mapped to both row
and header height. If a theme uses a larger header font that needs additional
space, it can increase resultsGridRowHeight as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
