codeant-ai-for-open-source[bot] commented on code in PR #41079:
URL: https://github.com/apache/superset/pull/41079#discussion_r3534305911
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Polygon/controlPanel.ts:
##########
@@ -222,6 +222,6 @@ const config: ControlPanelConfig = {
...formData,
metric: getStandardizedControls().shiftMetric(),
}),
-};
+};1
Review Comment:
**Suggestion:** The trailing `1` after the config object terminator is an
accidental stray token that introduces an unintended no-op expression
statement; remove it to avoid committing obvious typo noise and potential
lint/build failures under strict no-unused-expression rules. [typo]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Frontend `npm run lint` fails on Polygon controlPanel.
- ❌ CI job `npm run lint:full` fails during lint step.
- ⚠️ Dead expression noise in deck.gl Polygon control config.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. From repository root, run `cd superset-frontend && npm run lint` (lint
script defined
in `superset-frontend/package.json` lines 39–57).
2. The `lint` script executes `npx oxlint --config oxlint.json --quiet` using
configuration from `superset-frontend/oxlint.json` lines 1–17.
3. Oxlint lints
`plugins/preset-chart-deckgl/src/layers/Polygon/controlPanel.ts`, which
currently ends with `};1` at the module scope (PR hunk line 225; verified in
the file
contents).
4. The bare numeric literal `1` is parsed as an unused expression statement;
oxlint’s core
rules flag it as an error, causing `npm run lint` (and any CI job invoking
it, such as
`lint:full`) to exit non‑zero.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=871b4c59ddce41fa9821c3ad27465b58&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=871b4c59ddce41fa9821c3ad27465b58&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/preset-chart-deckgl/src/layers/Polygon/controlPanel.ts
**Line:** 225:225
**Comment:**
*Typo: The trailing `1` after the config object terminator is an
accidental stray token that introduces an unintended no-op expression
statement; remove it to avoid committing obvious typo noise and potential
lint/build failures under strict no-unused-expression rules.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41079&comment_hash=f7955959e29c7aac74a6a329278e9764bc13556745383393b86c4e8219c0b88f&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41079&comment_hash=f7955959e29c7aac74a6a329278e9764bc13556745383393b86c4e8219c0b88f&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
