codeant-ai-for-open-source[bot] commented on code in PR #40449: URL: https://github.com/apache/superset/pull/40449#discussion_r3534536459
########## superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx: ########## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + ComponentType, + useCallback, + useMemo, + useRef, + useState, + useEffect, +} from 'react'; +import { + QueryData, + QueryFormData, + BinaryQueryObjectFilterClause, + FeatureFlag, + isFeatureEnabled, +} from '@superset-ui/core'; +import { css } from '@apache-superset/core/theme'; +import { useDrillDownState } from './useDrillDownState'; +import { DrillDownBreadcrumb } from './DrillDownBreadcrumb'; +import type { ChartRendererProps } from '../ChartRenderer'; + +/** + * Hook payload contract: chart plugins call `onDrillDown(filters, label)` + * via the chart's hooks bag when the user clicks a data point and a + * drill-down hierarchy is configured. + */ +export type OnDrillDownHook = ( + filters: BinaryQueryObjectFilterClause[], + label: string, +) => void; + +interface DrillDownHostProps extends ChartRendererProps { + /** The wrapped renderer component */ + ChartRendererComponent: ComponentType< + ChartRendererProps & { onDrillDown?: OnDrillDownHook } + >; +} + +/** + * Wraps `<ChartRenderer>` with drill-down behavior. When the chart's + * form_data declares a `drilldown_hierarchy`, this host: + * + * 1. Tracks how deep the user has drilled (a stack of levels) + * 2. Computes "effective" form_data for the current level (replacing the + * groupby and adding accumulated filters) + * 3. Re-fetches chart data for that level + * 4. Renders a breadcrumb above the chart for navigating back up + * + * If the chart has no hierarchy, this is a thin pass-through. + */ +export function DrillDownHost({ + ChartRendererComponent, + ...rendererProps +}: DrillDownHostProps) { + const { formData, queriesResponse } = rendererProps; + + const { + isDrilling, + drillStack, + selectedLeaf, + hierarchy, + effectiveFormData, + effectiveQueriesResponse, + isLoading, + error, + hasHierarchy, + drillDown, + resetTo, + } = useDrillDownState({ + formData, + baseQueriesResponse: queriesResponse, + }); + + const onDrillDown = useMemo<OnDrillDownHook | undefined>(() => { + if (!hasHierarchy) { + return undefined; + } + return (filters, label) => { + drillDown(filters, label); + }; + }, [hasHierarchy, drillDown]); + + const overlayProps = useMemo<Partial<ChartRendererProps>>(() => { + if (!isDrilling) { + // Force re-render when returning to base level + return { triggerRender: true }; + } + return { + formData: effectiveFormData as QueryFormData, + queriesResponse: (effectiveQueriesResponse ?? null) as QueryData[] | null, + chartStatus: isLoading ? 'loading' : 'rendered', + latestQueryFormData: effectiveFormData, + chartIsStale: false, + triggerRender: true, + }; + }, [isDrilling, effectiveFormData, effectiveQueriesResponse, isLoading]); + + const handleResetTo = useCallback( + (depth: number) => { + resetTo(depth); + // Update cross-filter to match the level we're jumping to + if (rendererProps.actions?.updateDataMask) { + if (depth === 0) { + // Going back to root β clear cross-filter entirely + rendererProps.actions.updateDataMask(rendererProps.chartId, { + extraFormData: { filters: [] }, + filterState: { value: null, selectedValues: null }, + }); + // While drilled, the dashboard may have skipped re-querying this + // chart's base when other charts' cross-filters changed (e.g. one + // was cleared), leaving the Redux base query result stale/filtered. + // Trigger a fresh base query so returning to the top level shows the + // full chart. Unlike refreshChart (which reuses latestQueryFormData), + // triggerQuery makes the chart re-run with its current dashboard + // form_data, which reflects the now-cleared filters. + rendererProps.actions.triggerQuery?.(true, rendererProps.chartId); + } else { + // Going to an intermediate level β rebuild accumulated filters + // from all levels up to the target depth (mirroring effectiveFormData) + const accumulatedFilters = drillStack.slice(0, depth).flatMap(level => + level.filters.map(f => ({ + col: f.col, + op: 'IN' as const, + val: [f.val] as (string | number | boolean)[], + })), + ); Review Comment: **Suggestion:** When rebuilding cross-filters for breadcrumb jumps, null drill values are always converted into `IN [null]`. SQL filtering with `IN (NULL)` does not match null rows, so drilling on a null bucket and navigating via breadcrumb will produce incorrect filtering. Preserve null semantics by emitting an `IS NULL` filter when a drilled value is null (matching existing cross-filter behavior). [incorrect condition logic] <details> <summary><b>Severity Level:</b> Critical π¨</summary> ```mdx - β Drill-down breadcrumb breaks filters for null dimension values. - β οΈ Dashboards show empty charts when drilling into nulls. ``` </details> <details> <summary><b>Steps of Reproduction β </b></summary> ```mdx 1. In `superset-frontend/src/components/Chart/Chart.tsx:96-134`, the `Chart` component renders `DrillDownHost` with `ChartRenderer` and passes `actions.updateDataMask` and `chartId`, so any drill breadcrumb navigation will invoke `DrillDownHost`βs `handleResetTo`. 2. In `superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx:115-155`, `handleResetTo` rebuilds cross-filters for intermediate breadcrumb levels by computing `accumulatedFilters` from `drillStack.slice(0, depth)` and calling `rendererProps.actions.updateDataMask(chartId, { extraFormData: { filters: accumulatedFilters }, ... })`. 3. The drill stack filters are populated when plugins call `onDrillDown`: for generic ECharts charts, `superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts:175-207` builds `drillFilters` with entries like `{ col: dimension, op: '==', val: values[i], formattedVal: ... }` and calls `onDrillDown(drillFilters, label)`, so `drillStack[level].filters` can contain `val === null` when the underlying dimension value is null. 4. Cross-filter behavior for nulls uses `IS NULL`: in `eventHandlers.ts:61-81`, `getCrossFilterDataMask` maps null-only selections to `{ col, op: 'IS NULL' }` (no `val`), ensuring null buckets filter correctly, but `DrillDownHost.tsx:137-142` rebuilds filters as `{ col: f.col, op: 'IN', val: [f.val] }` even when `f.val` is `null`, producing `IN (NULL)` clauses that match no rows, so drilling into a null bucket and then jumping via the breadcrumb yields an incorrect empty cross-filter instead of preserving the null selection. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=83195b4801d942aabe7c356ed1e314c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=83195b4801d942aabe7c356ed1e314c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent π€ </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx **Line:** 137:143 **Comment:** *Incorrect Condition Logic: When rebuilding cross-filters for breadcrumb jumps, null drill values are always converted into `IN [null]`. SQL filtering with `IN (NULL)` does not match null rows, so drilling on a null bucket and navigating via breadcrumb will produce incorrect filtering. Preserve null semantics by emitting an `IS NULL` filter when a drilled value is null (matching existing cross-filter behavior). Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=483cb1d10c514a9989e25aa90fe373c5cbfff8b886166ed7a3453af59942f673&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=483cb1d10c514a9989e25aa90fe373c5cbfff8b886166ed7a3453af59942f673&reaction=dislike'>π</a> ########## superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx: ########## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { + ComponentType, + useCallback, + useMemo, + useRef, + useState, + useEffect, +} from 'react'; +import { + QueryData, + QueryFormData, + BinaryQueryObjectFilterClause, + FeatureFlag, + isFeatureEnabled, +} from '@superset-ui/core'; +import { css } from '@apache-superset/core/theme'; +import { useDrillDownState } from './useDrillDownState'; +import { DrillDownBreadcrumb } from './DrillDownBreadcrumb'; +import type { ChartRendererProps } from '../ChartRenderer'; + +/** + * Hook payload contract: chart plugins call `onDrillDown(filters, label)` + * via the chart's hooks bag when the user clicks a data point and a + * drill-down hierarchy is configured. + */ +export type OnDrillDownHook = ( + filters: BinaryQueryObjectFilterClause[], + label: string, +) => void; + +interface DrillDownHostProps extends ChartRendererProps { + /** The wrapped renderer component */ + ChartRendererComponent: ComponentType< + ChartRendererProps & { onDrillDown?: OnDrillDownHook } + >; +} + +/** + * Wraps `<ChartRenderer>` with drill-down behavior. When the chart's + * form_data declares a `drilldown_hierarchy`, this host: + * + * 1. Tracks how deep the user has drilled (a stack of levels) + * 2. Computes "effective" form_data for the current level (replacing the + * groupby and adding accumulated filters) + * 3. Re-fetches chart data for that level + * 4. Renders a breadcrumb above the chart for navigating back up + * + * If the chart has no hierarchy, this is a thin pass-through. + */ +export function DrillDownHost({ + ChartRendererComponent, + ...rendererProps +}: DrillDownHostProps) { + const { formData, queriesResponse } = rendererProps; + + const { + isDrilling, + drillStack, + selectedLeaf, + hierarchy, + effectiveFormData, + effectiveQueriesResponse, + isLoading, + error, + hasHierarchy, + drillDown, + resetTo, + } = useDrillDownState({ + formData, + baseQueriesResponse: queriesResponse, + }); + + const onDrillDown = useMemo<OnDrillDownHook | undefined>(() => { + if (!hasHierarchy) { + return undefined; + } + return (filters, label) => { + drillDown(filters, label); + }; + }, [hasHierarchy, drillDown]); + + const overlayProps = useMemo<Partial<ChartRendererProps>>(() => { + if (!isDrilling) { + // Force re-render when returning to base level + return { triggerRender: true }; + } + return { + formData: effectiveFormData as QueryFormData, + queriesResponse: (effectiveQueriesResponse ?? null) as QueryData[] | null, + chartStatus: isLoading ? 'loading' : 'rendered', + latestQueryFormData: effectiveFormData, + chartIsStale: false, + triggerRender: true, + }; + }, [isDrilling, effectiveFormData, effectiveQueriesResponse, isLoading]); + + const handleResetTo = useCallback( + (depth: number) => { + resetTo(depth); + // Update cross-filter to match the level we're jumping to + if (rendererProps.actions?.updateDataMask) { + if (depth === 0) { + // Going back to root β clear cross-filter entirely + rendererProps.actions.updateDataMask(rendererProps.chartId, { + extraFormData: { filters: [] }, + filterState: { value: null, selectedValues: null }, + }); + // While drilled, the dashboard may have skipped re-querying this + // chart's base when other charts' cross-filters changed (e.g. one + // was cleared), leaving the Redux base query result stale/filtered. + // Trigger a fresh base query so returning to the top level shows the + // full chart. Unlike refreshChart (which reuses latestQueryFormData), + // triggerQuery makes the chart re-run with its current dashboard + // form_data, which reflects the now-cleared filters. + rendererProps.actions.triggerQuery?.(true, rendererProps.chartId); + } else { + // Going to an intermediate level β rebuild accumulated filters + // from all levels up to the target depth (mirroring effectiveFormData) + const accumulatedFilters = drillStack.slice(0, depth).flatMap(level => + level.filters.map(f => ({ + col: f.col, + op: 'IN' as const, + val: [f.val] as (string | number | boolean)[], + })), + ); + const labels = drillStack.slice(0, depth).map(l => l.label); + rendererProps.actions.updateDataMask(rendererProps.chartId, { + extraFormData: { filters: accumulatedFilters }, + filterState: { + value: labels, + selectedValues: labels, + }, + }); + } + } + }, + [resetTo, rendererProps.actions, rendererProps.chartId, drillStack], + ); + + const breadcrumbRef = useRef<HTMLDivElement>(null); + const [breadcrumbHeight, setBreadcrumbHeight] = useState(0); + + useEffect(() => { + if (breadcrumbRef.current) { + setBreadcrumbHeight(breadcrumbRef.current.offsetHeight); + } else { + setBreadcrumbHeight(0); + } + }, [drillStack.length]); + + if (!hasHierarchy || !isFeatureEnabled(FeatureFlag.DrillDownHierarchy)) { + return <ChartRendererComponent {...rendererProps} />; + } + + // Reduce chart height by the breadcrumb height + const adjustedHeight = + rendererProps.height && breadcrumbHeight > 0 + ? rendererProps.height - breadcrumbHeight + : rendererProps.height; Review Comment: **Suggestion:** The adjusted chart height can become negative when the breadcrumb is taller than the available chart height, which can lead to invalid chart sizing and render glitches. Clamp the computed height to a non-negative minimum before passing it to the renderer. [css layout issue] <details> <summary><b>Severity Level:</b> Major β οΈ</summary> ```mdx - β οΈ Drill-down charts can receive negative heights in dashboards. - β οΈ Charts may render collapsed or visually corrupted. ``` </details> <details> <summary><b>Steps of Reproduction β </b></summary> ```mdx 1. In `superset-frontend/src/components/Chart/Chart.tsx:96-134`, `Chart` renders a `.slice_container` with `height={height}` and mounts `DrillDownHost` with the same `height` prop passed through as `rendererProps.height` (e.g., a small dashboard row height). 2. In `superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx:158-167`, the breadcrumb ref measures `breadcrumbHeight = breadcrumbRef.current.offsetHeight` whenever the drill stack changes, which can be larger than a very small `rendererProps.height`. 3. The adjusted height is computed at `DrillDownHost.tsx:173-177` as `const adjustedHeight = rendererProps.height && breadcrumbHeight > 0 ? rendererProps.height - breadcrumbHeight : rendererProps.height;`, so if `rendererProps.height` is, for example, 20px while `breadcrumbHeight` is 40px, `adjustedHeight` becomes `-20`. 4. That negative `adjustedHeight` is passed to `ChartRendererComponent` at `DrillDownHost.tsx:216-219`, and `ChartRenderer` forwards `height={height}` directly to `SuperChart` in `superset-frontend/src/components/Chart/ChartRenderer.tsx:271-279` without clamping, so the rendered chart receives a negative height, leading to invalid sizing and potential render glitches when the drill-down breadcrumb is taller than the available chart area. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9e748b339b484571ae7c2076363d5ca7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9e748b339b484571ae7c2076363d5ca7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent π€ </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/components/Chart/DrillDown/DrillDownHost.tsx **Line:** 174:177 **Comment:** *Css Layout Issue: The adjusted chart height can become negative when the breadcrumb is taller than the available chart height, which can lead to invalid chart sizing and render glitches. Clamp the computed height to a non-negative minimum before passing it to the renderer. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=2bd71a855a65f05e37ebd5e7fe649e272f45e3aa1fc218ce3f2b1a92956a3cf3&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=2bd71a855a65f05e37ebd5e7fe649e272f45e3aa1fc218ce3f2b1a92956a3cf3&reaction=dislike'>π</a> ########## superset-frontend/src/components/Chart/DrillDown/useDrillDownState.test.ts: ########## @@ -0,0 +1,387 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { act, renderHook, waitFor } from '@testing-library/react'; +import { QueryFormData } from '@superset-ui/core'; +import { useDrillDownState, clearDrillDownState } from './useDrillDownState'; + +jest.mock('src/components/Chart/chartAction', () => ({ + getChartDataRequest: jest.fn(() => + Promise.resolve({ response: {}, json: { result: [{ data: [] }] } }), + ), + handleChartDataResponse: jest.fn(() => + Promise.resolve([{ data: [{ col1: 'val1' }] }]), + ), +})); + +jest.mock('src/explore/exploreUtils', () => ({ + getQuerySettings: jest.fn(() => [false]), +})); + +jest.mock('src/utils/simpleFilterToAdhoc', () => ({ + simpleFilterToAdhoc: jest.fn(filter => ({ + expressionType: 'SIMPLE', + clause: 'WHERE', + operator: filter.op, + subject: filter.col, + comparator: filter.val, + })), +})); + +const baseFormData: QueryFormData = { + datasource: '1__table', + viz_type: 'echarts_timeseries_bar', + slice_id: 42, + x_axis: 'country', + groupby: [], + adhoc_filters: [], +}; + +beforeEach(() => { + // Drill state persists in a module-level store keyed by chart id; clear it + // so each test starts from a clean slate (tests reuse slice_id 42). + clearDrillDownState(); +}); + +test('hierarchy is empty when x_axis is a single string with no drilldown_hierarchy', () => { + const { result } = renderHook(() => + useDrillDownState({ + formData: baseFormData, + baseQueriesResponse: [{ data: [] }], + }), + ); + + expect(result.current.hierarchy).toEqual([]); + expect(result.current.hasHierarchy).toBe(false); +}); + +test('hierarchy is built from x_axis array with 2+ items', () => { + const formData = { + ...baseFormData, + x_axis: 'country', + drilldown_hierarchy: ['country', 'region', 'city'], + }; Review Comment: **Suggestion:** The test title claims hierarchy is derived from an `x_axis` array, but the test data uses `x_axis` as a string and relies on `drilldown_hierarchy`; this is a misleading description that contradicts what is actually being tested. Rename the test description to reflect the real input source. [comment mismatch] <details> <summary><b>Severity Level:</b> Minor π§Ή</summary> ```mdx - β οΈ Test name misrepresents drilldown hierarchy configuration source. - β οΈ Developers may misunderstand supported hierarchy inputs. ``` </details> <details> <summary><b>Steps of Reproduction β </b></summary> ```mdx 1. In `superset-frontend/src/components/Chart/DrillDown/useDrillDownState.ts:194-209`, the `hierarchy` memo reads the drill columns exclusively from `formData.drilldown_hierarchy` or `formData.drilldownHierarchy`, using `ensureIsArray(fd[HIERARCHY_FIELD] ?? fd[HIERARCHY_FIELD_CAMEL])`, and returns an empty array if there are not at least two entries; there is no logic that derives hierarchy from `x_axis` arrays. 2. In `superset-frontend/src/components/Chart/DrillDown/useDrillDownState.test.ts:73-79`, the test named `hierarchy is built from x_axis array with 2+ items` constructs `formData` with `x_axis: 'country'` (a string, not an array) and `drilldown_hierarchy: ['country', 'region', 'city']`, then asserts `result.current.hierarchy` equals that drilldown array. 3. The next test `hierarchy is built from drilldown_hierarchy field` at `useDrillDownState.test.ts:91-107` uses the same `drilldown_hierarchy` setup, so both tests validate the same input source, while none cover an `x_axis` array scenario, contradicting the βx_axis arrayβ wording in the earlier test name. 4. As a result, the test title misleads readers into believing hierarchy can be derived from an `x_axis` array, even though the implementation and test data rely solely on `drilldown_hierarchy`, so renaming this test to reference `drilldown_hierarchy` would better document the actual behavior without changing runtime semantics. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f51616955fbf45a69678716d66d3b1df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f51616955fbf45a69678716d66d3b1df&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent π€ </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/components/Chart/DrillDown/useDrillDownState.test.ts **Line:** 73:78 **Comment:** *Comment Mismatch: The test title claims hierarchy is derived from an `x_axis` array, but the test data uses `x_axis` as a string and relies on `drilldown_hierarchy`; this is a misleading description that contradicts what is actually being tested. Rename the test description to reflect the real input source. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=c8d6e57802d7924da1639501678139b31c0da4d4c23963c2e74fbc245f160953&reaction=like'>π</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40449&comment_hash=c8d6e57802d7924da1639501678139b31c0da4d4c23963c2e74fbc245f160953&reaction=dislike'>π</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
