codeant-ai-for-open-source[bot] commented on code in PR #41075:
URL: https://github.com/apache/superset/pull/41075#discussion_r3537956719
##########
superset/commands/importers/v1/utils.py:
##########
@@ -387,6 +388,37 @@ def safe_insert_dashboard_chart_relationships(
)
+def _prime_versioning_unit_of_work() -> None:
+ """Ensure Continuum has a unit-of-work for the current connection.
+
+ ``dashboard_slices`` is a Continuum-tracked (versioned) association
+ table, so a raw Core INSERT/DELETE on it fires Continuum's engine-level
+ ``before_execute`` listener, which looks up a unit-of-work for the
+ connection and raises ``KeyError`` when none is registered (the same
+ failure class the dashboard test factory hit). The normal import flow
+ registers one via prior ORM flushes, so this is belt-and-suspenders for
+ a bulk relationship insert that might run before any flush on the
+ connection. No-op (the listener is detached) when version capture is
+ disabled, which is the shipped default; never allowed to break an import.
+ """
+ try:
+ # pylint: disable=import-outside-toplevel
+ from sqlalchemy_continuum import versioning_manager
+
+ # Mirror the exact condition Continuum's track_association_operations
+ # listener uses to decide whether it acts (versioning OR
+ # native_versioning), so the prime can't skip while the listener runs.
+ options = versioning_manager.options
Review Comment:
**Suggestion:** Add an explicit type annotation for the local `options`
mapping to satisfy the type-hint requirement for relevant newly introduced
variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The suggestion matches the custom Python type-hint rule: this is newly added
code, and the local variable `options` is assigned a value whose type can be
annotated. Since no type hint is present, this is a real violation of the
stated rule.
</details>
<details>
<summary><b>Rule source 📖 </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=81bbfcf25e4a4b049873158de85318f0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=81bbfcf25e4a4b049873158de85318f0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/importers/v1/utils.py
**Line:** 411:411
**Comment:**
*Custom Rule: Add an explicit type annotation for the local `options`
mapping to satisfy the type-hint requirement for relevant newly introduced
variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41075&comment_hash=28bc4b6a9728b0c30784aa847fa900d4263b55c37352fa3d0778cdcef720cf61&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41075&comment_hash=28bc4b6a9728b0c30784aa847fa900d4263b55c37352fa3d0778cdcef720cf61&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
