rusackas commented on code in PR #41132:
URL: https://github.com/apache/superset/pull/41132#discussion_r3538260508
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/hooks/useFilterOperations.ts:
##########
@@ -125,7 +125,7 @@ export function useFilterOperations({
);
const handleRearrangeFilters = useCallback(
- (dragIndex: number, targetIndex: number, id: string) => {
+ (dragIndex: number, targetIndex: number, _id: string) => {
Review Comment:
`handleRearrangeFilters` is a positional DnD callback — the caller invokes
it as `(dragIndex, targetIndex, id)`, so dropping the third arg would break the
signature. The `_id` rename is the lint fix, not new dead code.
##########
superset-frontend/src/explore/components/ExploreAlert.tsx:
##########
@@ -51,7 +51,7 @@ export const ExploreAlert = forwardRef(
type = 'info',
className = '',
}: ControlPanelAlertProps,
- ref: RefObject<HTMLDivElement>,
+ _ref: RefObject<HTMLDivElement>,
Review Comment:
The `_ref` rename is just the lint fix here. Dropping `forwardRef` would
change the component contract for any caller passing a ref, so that feels like
a separate refactor rather than something for this cleanup PR.
##########
superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.tsx:
##########
@@ -92,7 +92,7 @@ const MatrixNoDataComponent = () => {
* Individual grid cell component - memoized to prevent unnecessary re-renders
*/
const MatrixifyGridCell = memo(
- ({ cell, rowHeight, datasource, hooks }: MatrixifyGridCellProps) => {
+ ({ cell, hooks }: MatrixifyGridCellProps) => {
Review Comment:
No crash here — `rowHeight` is still passed by `MatrixifyGridRenderer` and
read by the memo comparator via `prevProps`/`nextProps`, so it stays on the
interface. I only dropped it from the render destructure where it was genuinely
unused; removing it from the comparator would break re-render on height change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
