rusackas commented on code in PR #41318:
URL: https://github.com/apache/superset/pull/41318#discussion_r3538449369
##########
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorScale.ts:
##########
@@ -396,17 +396,24 @@ class CategoricalColorScale extends ExtensibleFunction {
/**
* Returns the current unknown value, which defaults to "implicit".
*/
- unknown(): string | { name: 'implicit' };
+ unknown(): { name: 'implicit' };
Review Comment:
Good catch — the narrowed getter type was inaccurate; `unknown()` can return
a string at runtime (see the existing unit tests), not just the implicit
marker. Pushed a fix that restores the `string | { name: 'implicit' }` union,
verified against the real `@types/[email protected]` types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
