rusackas commented on PR #41799: URL: https://github.com/apache/superset/pull/41799#issuecomment-4909999328
Thanks @Pawansingh3889. The backend gate is the real enforcement here, so no security concern, this is just about button visibility. On the fallback question you raised: I'd lean toward matching what the backend actually enforces. With the flag on it wants `can_export_data` only (no `can_csv` fallback), and `hydrateExplore`/`usePermissions` do the same, so keeping the `can_csv` fallback only here means a `can_csv`-only user sees the Download button and then hits a 403. I'd drop the fallback when the flag's on so the frontend lines up... `granularExport ? can_export_data : can_csv`. If we do want the more forgiving behavior, it'd need to go everywhere (backend included), or the button still fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
