rusackas commented on PR #41536: URL: https://github.com/apache/superset/pull/41536#issuecomment-4910060120
As mentioned, I was tempted to close this since the old diff just moved the `isDescriptionExpanded` prop up the list. But you've reworked it into a `ResizeObserver` height fix in `Chart.tsx` now, which is a real change... the description height gets re-measured once the async markdown lays out instead of reading 0 at first paint. That part looks right to me. Couple of things: the title/body still describe the old SliceHeader approach, mind updating them to match the actual fix? And can you spell out which symptom from #40373 this resolves, so I can verify it end to end? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
