rusackas commented on PR #40905: URL: https://github.com/apache/superset/pull/40905#issuecomment-4910116811
Thanks @ashah65. The core change, swapping the hardcoded `ALLOW_DEPENDENCIES` list for the registry-driven `supportsCascadeDependencies` flag, is clean, and the core filters map to the exact same behavior as before, so no regression to the cascade gate. Two things: this PR is also carrying an `isColumnSelect` control, a divider change-tracking refactor, and a `ControlLabel` change that aren't really part of the titled feature. Any chance of splitting those out? The dependency change stands on its own, and the riders widen the review surface a fair bit. There's also a small bug in the new `isColumnSelect` path the bot flagged... left a suggestion on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
