rusackas commented on PR #38584: URL: https://github.com/apache/superset/pull/38584#issuecomment-4910132967
Thanks @mkramer5454. Enforcing the managed-dashboard block in the create/update commands is the right place for it, since that's what actually gates the API regardless of the frontend. That part looks solid. It's conflicting with master though, so it'll need a rebase before we can merge. And a small thing while you're in there: looks like the new `is_managed_externally or not is_owner` loop in `update.py` makes the old 'Additional ownership check' loop just below it redundant, so that can probably come out. Holler if you want a hand with the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
