rusackas commented on PR #36081: URL: https://github.com/apache/superset/pull/36081#issuecomment-4910167670
The fix itself looks right to me... keying the border off `rowIdx + rowSpan === visibleRowCount` correctly targets the cell that bottoms out the table, and withholding it when column totals are on so the totals row owns the edge is the right call. The open thing is @sadpandajoe's point: the fixtures are all flat (rowSpan=1), so they don't actually exercise the merged-cell case from #36031... a full revert would still pass them. As I mentioned, I'll see about pushing a two-dimension fixture (a country with a couple of cities) that pins `pvtRowLabelLast` landing on the spanning `th`, then we can get it merged. Thanks for your patience here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
