gkneighb commented on PR #41842: URL: https://github.com/apache/superset/pull/41842#issuecomment-4911102670
Sorted — all 8 threads triaged and resolved. Applied: LLM-context sanitization of chart/dashboard names in the restore responses (matching the get/list convention) and fixture annotations. Disputed in-thread: the two suggestions to reorder the NotDeleted check behind an ownership gate — BaseRestoreCommand.validate itself checks deleted_at before raise_for_ownership, so the tool mirrors the REST endpoint's exact semantics; and the logger/local annotation nits (not repo convention). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
