eschutho opened a new pull request, #41878:
URL: https://github.com/apache/superset/pull/41878
## Summary
The per-row "remove dependency" icon in the native filter dependency list
(`DependencyList.tsx`'s `Row` component) had an `onClick` handler but no
accessible name. `BaseIcon`'s auto-generated fallback label ("delete") is
generic and doesn't tell a screen reader user which item will be removed or
from what list.
- **WCAG 2.1 SC 4.1.2 (Name, Role, Value) — Level A**
- Adds `aria-label={t('Remove dependency')}` to the `DeleteFilter` icon in
`superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/DependencyList.tsx`
- Behavior is unchanged — purely additive `aria-label`, no visual or
functional change
- Single call site of this icon in the file (confirmed via grep)
## Test plan
- [ ] Open a dashboard's native filter config modal, enable "Values are
dependent on other filters" on a filter with 2+ dependency candidates
- [ ] Tab to the delete icon next to a dependency row with a screen reader
running (VoiceOver/NVDA) and verify it announces "Remove dependency, button"
instead of the generic "delete, button"
- [ ] Confirm clicking the icon still removes the row as before (no behavior
change)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
