rusackas opened a new pull request, #41882: URL: https://github.com/apache/superset/pull/41882
### SUMMARY Dependabot opened four separate PRs bumping ag-grid 35.3.1 → 36.0.0 — `ag-grid-community` and `ag-grid-react`, each in both `superset-frontend/` and `superset-frontend/packages/superset-ui-core/` (#41676, #41674, #41668, #41667). Because these two packages share one root lockfile, every partial bump left a `community`/`react` (or root/workspace) version mismatch, so all four fail CI and none can merge on their own. This does the upgrade in one shot: all four declarations → `36.0.0`, one lockfile regeneration, and the one code fix v36 actually requires. Supersedes and closes the four Dependabot PRs. **What v36 needed (and didn't):** - **Compiles under our current TypeScript 5.4.5** with zero type errors, despite v36 docs recommending ≥5.8.3. Verified via `tsc --build` across all packages and `tsc --noEmit` on the app. - Every AG Grid module we register (including `ClientSideRowModelModule` and `ValidationModule`), every re-exported type, and every theming-API param we pass **still exists in v36** — so **no production source changed**. - v36 renamed some internal DOM container classes. Updated three stale selectors in the ag-grid-table test: `.ag-floating-bottom` → `.ag-grid-pinned-bottom-rows`, and `.ag-body-viewport` / `.ag-center-cols-container` → `.ag-grid-viewport`. (Two of these had been passing only because the old selector matched nothing, so this restores real assertions.) Class names our non-test code depends on — `.ag-root-wrapper`, `.ag-cell`, `.ag-header-cell*`, etc. — are unchanged in v36. - v36's module split adds two new transitive deps: `[email protected]` and `[email protected]`. ### TESTING INSTRUCTIONS - `plugin-chart-ag-grid-table` suite: 290 tests pass (was 1 failing on the renamed selector). - Core `ThemedAgGridReact` + `GridTable` + `downloadAsImage` suites: 66 tests pass. - **Please eyeball a rendered grid in a running instance** (AG Grid table viz, SQL Lab results, dashboard grid): v36 changed two theme defaults we don't explicitly override — `fontWeight` now defaults to `400` (previously inherited) and `borderRadius` now applies to filter picker fields. Cosmetic, but worth a visual confirmation that headers/cells and filter inputs still look right in light and dark mode. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API Dependency upgrade only; no runtime/API changes. Closes #41676, #41674, #41668, #41667. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
