betodealmeida commented on a change in pull request #8389: Allow fetching all
rows from results endpoint
URL:
https://github.com/apache/incubator-superset/pull/8389#discussion_r337174170
##########
File path: superset/views/utils.py
##########
@@ -176,7 +176,9 @@ def get_datasource_info(
return datasource_id, datasource_type
-def apply_display_max_row_limit(sql_results: Dict[str, Any]) -> Dict[str, Any]:
+def apply_display_max_row_limit(
+ sql_results: Dict[str, Any], rows: Optional[int] = None
Review comment:
Yes, synchronous queries will still call this to limit the response:
```
payload = json.dumps(
apply_display_max_row_limit(data),
default=utils.pessimistic_json_iso_dttm_ser,
ignore_nan=True,
encoding=None,
)
```
I think it makes sense to limit the sync response, disallowing users from
bypassing it. if the query is returned more than `DISPLAY_MAX_ROWS` and the
user needs that data they should run it asynchronously, IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
