aminghadersohi commented on code in PR #40956: URL: https://github.com/apache/superset/pull/40956#discussion_r3546766100
########## tests/unit_tests/mcp_service/dashboard/tool/test_delete_dashboard.py: ########## @@ -0,0 +1,197 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Unit tests for the delete_dashboard MCP tool. + +Covers: +- Successful delete with SOFT_DELETE on (recoverable) and off (permanent) +- confirm=false refusal (safety gate) +- Dashboard not found +- Permission denied (user does not own the dashboard) +- Delete failure (e.g. associated alerts or reports) +""" + +from collections.abc import Iterator +from unittest.mock import Mock, patch Review Comment: Declining for this PR: every existing tool test file in `tests/unit_tests/mcp_service/dashboard/tool/` (11 of 12) defines its own `mcp_server`/`mock_auth` fixtures and there is no tool-level `conftest.py` — the per-file pattern is the established convention of this suite. Consolidating fixtures for the whole directory is a broader refactor that shouldn't ride along on this feature PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
