madhushreeag commented on PR #41007:
URL: https://github.com/apache/superset/pull/41007#issuecomment-4919702524
> @madhushreeag thanks to working on this, how about this one?
>
> * superset/config.py:1132 — THEME_DEFAULT_MODE accepts Literal["light",
"dark", "system"], but the internal ThemeMode value for light is "default" and
the config is named …DEFAULT_MODE, so "default" is the intuitive value an
operator will try — yet it's rejected by the Literal and would silently fall
back to SYSTEM at runtime (modeMap has no default key). villebro requested
Literal["default", "dark", "system"] = "default"; the reply "Fixed this" added
the Literal annotation but kept "light"/"system", so the naming mismatch the
suggestion targeted is unresolved. Either align the config value with the enum
("default") or add "default" as an accepted alias in modeMap. (villebro
approved, so this is a judgment call — flagging because the config name itself
invites the wrong value.)
Thanks for your review :) Yes, this is a confusing situation here. I renamed
it back to "default" instead of "light"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
