bito-code-review[bot] commented on code in PR #41898:
URL: https://github.com/apache/superset/pull/41898#discussion_r3547946382
##########
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx:
##########
@@ -63,7 +64,10 @@ const StyledDivider = styled.div`
margin: 0 -${({ theme }) => theme.sizeUnit * 2.5}px 0;
`;
-const SqlEditorLeftBar = ({ queryEditorId }: SqlEditorLeftBarProps) => {
+const SqlEditorLeftBar = ({
+ queryEditorId,
+ collapsed = false,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing collapsed prop tests</b></div>
<div id="fix">
Rule [6262] requires tests to verify actual behavior logic. The new
`collapsed` prop has two distinct render paths (lines 212-214) but no test
coverage validates this behavior or confirms `compactMode` is passed to
`DatabaseSelector` at line 205. Add tests for both paths to prevent regressions.
</div>
</div>
<small><i>Code Review Run #4367b7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
