tomerkl65 commented on PR #41907:
URL: https://github.com/apache/superset/pull/41907#issuecomment-4925551061
This supersedes #40449, which I had to close and recreate — the branch was
force-pushed so GitHub wouldn't let me reopen it. The code here is the same
feature, cleaned up and rebased on current master.
@michael-s-molina @villebro @EnxDev — following up on the earlier review,
this
branch addresses the feedback:
- **No global `multi` change.** Reverted `xAxisMixin` to `multi: false`; the
hierarchy is now configured via a dedicated `drilldown_hierarchy` control,
so
x_axis stays a scalar column and no downstream consumer
(normalizeTimeColumn,
operators, backend QueryObject) is affected. No feature flag needed.
- **Treemap/Sunburst removed** from the supported set. Supported: Bar, Line,
Area, Scatter, Smooth Line, Step, Pie, Funnel, Gauge, Radar, Box Plot.
- **Backend engine-listener fix dropped** — it already landed on master
separately.
- **Dead code removed** — the unused `DrillDownEvent` type and `options`
param
are gone; cross-filter emission is consolidated in the host.
- Breadcrumb uses native `<button>` (a11y) and theme spacing tokens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
