rusackas commented on PR #41352: URL: https://github.com/apache/superset/pull/41352#issuecomment-4926019188
Tried rebasing onto master and this isn't a simple textual conflict — #38831 landed and replaced `slice.owners` with the Subject-based `editors`/`viewers` model in `canOverwriteSlice()`, so this PR is normalizing a field that no longer exists on that codepath. Worth noting the object-shape bug itself already seems to be handled over there (same `typeof === 'number'` ternary on `editors`). Aborted the rebase rather than force something through — need to check whether #38911 still reproduces against the new editors model before reworking this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
