eschutho opened a new pull request, #41909:
URL: https://github.com/apache/superset/pull/41909
## What changed
**Deprecation warning found in production Datadog logs (still firing,
~250/day):**
```
The field `groupby` is deprecated, please use `columns` instead.
file: query_object.py, line 225, func: _rename_deprecated_fields
```
along with the sibling `timeseries_limit`, `timeseries_limit_metric`, and
`granularity_sqla` warnings from the same code path.
This exact warning was already fixed on `master` via #41204 (commit
7040388a), merged 2026-06-18. That fix normalizes the four `DEPRECATED_FIELDS`
inside `QueryObjectFactory.create()` *before* constructing `QueryObject`, so
`QueryObject._rename_deprecated_fields` never sees the old keys and never logs.
**The fix was never backported to `6.0-bug-fixes`.** Comparing release tags:
`v6.1.0.2` (2026-06-29) contains commit 7040388a; `v6.0.0.19` (2026-07-02) does
not. That's why this warning is still noisy in production three weeks after the
master fix landed — production is on the 6.0.x line, which never got the
backport.
## What was changed
Clean `git cherry-pick -x 7040388ad15605bc22f32665fe4edc157fa53564` onto
`6.0-bug-fixes`. No manual edits, no conflicts. Touches the same 2 files as the
original PR:
- `superset/common/query_object_factory.py` (+6/-1)
- `tests/unit_tests/common/test_query_object_factory.py` (+87, new tests)
## No behavior change
Charts using stored `query_context` with legacy `groupby`/`timeseries_limit`
keys continue to produce the same result — only the noisy warning log is
suppressed. See original PR #41204 for full rationale, including the bonus
correctness fix to x-axis temporal filter resolution for stored `groupby`-keyed
contexts.
## Test plan
- [x] Cherry-pick applies cleanly, diff verified identical to master commit
modulo cherry-pick metadata.
- [x] Self-reviewed: confirmed all production callers of `QueryObject` route
through `QueryObjectFactory.create()`, so the fix has full coverage on this
branch; confirmed falsy-value (e.g. `timeseries_limit=0`) semantics are
unchanged from pre-fix behavior.
- [ ] CI green on this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
