codeant-ai-for-open-source[bot] commented on code in PR #41597:
URL: https://github.com/apache/superset/pull/41597#discussion_r3555236883
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -306,6 +306,8 @@ class GetChartInfoRequest(BaseModel):
current chart configuration from cache.
"""
+ model_config = ConfigDict(populate_by_name=True)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag unannotated `model_config = ConfigDict(...)` assignments in
Pydantic v2 `BaseModel` classes; `BaseModel` already provides the typed
`model_config` attribute and no redundant annotation is needed.
**Applied to:**
- `**/*.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -262,6 +263,8 @@ class DatasetList(BaseModel):
class ListDatasetsRequest(EditedByMeMixin, CreatedByMeMixin,
MetadataCacheControl):
"""Request schema for list_datasets with clear, unambiguous types."""
+ model_config = ConfigDict(populate_by_name=True)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not require explicit type annotations for bare `model_config =
ConfigDict(...)` assignments in Pydantic v2 model classes when this is the
standard pattern and the file is mypy-clean.
**Applied to:**
- `**/*.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
