rusackas commented on PR #41505: URL: https://github.com/apache/superset/pull/41505#issuecomment-4930616445
The fix in general LGTM. The tests are failing CI because `getSmartDateFormatter` returns the `smart_date` stub when the time-format registry isn't set up, so `formatter(date)` is just `"smart_date"` for every input. We'd appreciate before/after screenshots to show the result on the labels, and any tests that solidify it. Happy to help if you get stuck on anything. Lastly, both files need a newline at the end to pass pre-commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
