bito-code-review[bot] commented on PR #41916:
URL: https://github.com/apache/superset/pull/41916#issuecomment-4931032718
<!-- Bito Reply -->
The suggestion to replace the `any` cast with a concrete type is correct and
improves type safety. You can resolve this by defining an interface for the
mocked module structure instead of using `as any`.
Here is the corrected implementation for the test file:
```typescript
// Replace line 53 with a concrete type definition
interface MockedChartControls {
__mockShiftMetric: jest.Mock;
}
const { __mockShiftMetric } = ChartControls as MockedChartControls;
```
There are no other comments on this PR to address. Would you like me to
apply this change to the test file?
**superset-frontend/plugins/legacy-preset-chart-nvd3/test/TimePivot/controlPanel.test.ts**
```
interface MockedChartControls {
__mockShiftMetric: jest.Mock;
}
const { __mockShiftMetric } = ChartControls as MockedChartControls;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
