rusackas commented on PR #41424: URL: https://github.com/apache/superset/pull/41424#issuecomment-4931139096
Thanks @gr33nak, this cleaned up nicely since the last pass! The CSV/XLSX merge into `_get_data` reads well and the timeout/failure classification tests cover the cases I'd worry about. One bot thread is still open though, the Bito one above. Mind adding a quick test for that one? Also conflicting with master again, needs another rebase (sorry, a huge swath of Python changes just merged). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
