rusackas commented on PR #36262:
URL: https://github.com/apache/superset/pull/36262#issuecomment-4931181304
As mentioned, I dug into this a bit further. Confirmed it in the actual
types: the persisted `value` is a `DataMaskStateWithId`, which is `{
[filterId]: DataMaskWithId }` in `@superset-ui/core`, so `value_dict.get("id")`
really will always come back `None` for a real dashboard, not just an edge case.
The bigger issue is that a single `name` field probably isn't the right
shape at all, since one cached entry can hold multiple filters' state at once.
I think this needs to return something like `{value, names: {filterId: name}}`,
cross-referencing `native_filter_configuration` on the dashboard rather than
trying to pull anything out of the cached blob itself. That's a bigger change
than the PR as it stands.
Happy to adopt this and push that version if you'd like some help getting it
over the line, @Yogi776, otherwise happy to leave it with you... just let me
know which you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
