rusackas commented on PR #37009: URL: https://github.com/apache/superset/pull/37009#issuecomment-4931678822
Went ahead and pushed a commit here. The `AUTH_LDAP` exclusion was hiding recaptcha entirely, which broke the DB/LDAP test already on master (it expects recaptcha to show when a key IS configured). So instead I reverted that exclusion and made the `RECAPTCHA_PUBLIC_KEY` lookup itself safe with `.get()`, which is really what #37008 and #39364 were asking for. Also added a regression test for the missing-key case, since that had no coverage before. Should be green now, will keep an eye on CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
