rusackas commented on PR #38033: URL: https://github.com/apache/superset/pull/38033#issuecomment-4933369444
navigationUtils — that's the barrel almost everything else on master imports `ensureAppRoot` from now (19 files vs. 1), pathUtils is more the internal implementation these days. Should be a drop-in swap. For the rebase itself, I don't think you need to touch `pathUtils.ts`, `pathUtils.test.ts`, or the app-root-prefixing bits of `Login.test.tsx`/`Register.test.tsx` at all — master's #39925 already covers that. The parts still uniquely yours are the OAuth login/register button work, the `app.py` icon prefixing, and the logout url fix, so those should be the only real conflicts. Holler if you get stuck on it, happy to jump in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
