michael-s-molina commented on code in PR #39171: URL: https://github.com/apache/superset/pull/39171#discussion_r3560959772
########## superset/extensions/storage/persistent.py: ########## @@ -0,0 +1,193 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Host implementation for Persistent State (Tier 3 Storage). + +Provides the concrete database-backed implementation that is injected into +superset_core.extensions.storage.persistent at startup. +""" + +from __future__ import annotations + +from typing import Any, ClassVar + +from flask import g +from superset_core.extensions.storage.persistent import ( + PersistentSetOptions, + PersistentState as CorePersistentState, +) + +from superset.extensions.context import get_current_extension_context +from superset.extensions.storage.persistent_dao import ExtensionStorageDAO +from superset.utils import json +from superset.utils.decorators import transaction + + +def _get_extension_id() -> str: + """Get the current extension ID from context.""" + context = get_current_extension_context() + if context is None: + raise RuntimeError( + "persistent_state can only be used within an extension context. " + "Ensure this code is being executed during extension loading or " + "within an extension API request handler." + ) + return context.manifest.id + + +def _get_current_user_id() -> int: + """Get the current authenticated user's ID.""" + user = getattr(g, "user", None) Review Comment: Done ########## superset/extensions/storage/ephemeral.py: ########## @@ -0,0 +1,181 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Host implementation for Ephemeral State (Tier 2 Storage). + +Provides the concrete cache-backed implementation that is injected into +superset_core.extensions.storage.ephemeral at startup. +""" + +from __future__ import annotations + +from typing import Any, ClassVar + +from flask import g +from superset_core.extensions.storage.ephemeral import ( + EphemeralSetOptions, + EphemeralState as CoreEphemeralState, +) + +from superset.extensions import cache_manager +from superset.extensions.context import get_current_extension_context + +# Key separator +SEPARATOR = ":" + +# Key prefix for extension ephemeral state +KEY_PREFIX = "superset-ext" + + +def _get_extension_id() -> str: + """Get the current extension ID from context.""" + context = get_current_extension_context() + if context is None: + raise RuntimeError( + "ephemeral_state can only be used within an extension context. " + "Ensure this code is being executed during extension loading or " + "within an extension API request handler." + ) + return context.manifest.id + + +def _get_current_user_id() -> int: + """Get the current authenticated user's ID.""" + user = getattr(g, "user", None) + if user is None or not hasattr(user, "id"): + raise RuntimeError( + "ephemeral_state requires an authenticated user. " + "Ensure the request has been authenticated." + ) + return user.id + + +def _build_cache_key(*parts: Any) -> str: + """Build a namespaced cache key from parts.""" + return SEPARATOR.join(str(part) for part in parts) Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
