mikebridge commented on PR #41910: URL: https://github.com/apache/superset/pull/41910#issuecomment-4938842051
Closing in favor of the broader transaction-correctness follow-up tracked in [sc-112938](https://app.shortcut.com/preset/story/112938). This PR proves the PostgreSQL transaction-poisoning problem for a failed parent baseline write, but its `begin_nested()` boundary runs inside the prepended `before_flush` listener and covers only the parent failure case. Follow-up investigation found that the complete fix also needs to prove parent/child atomic rollback, absence of partial baseline history, continued session usability, and compatibility with SQLAlchemy-Continuum canonical shadow generation. The replacement work is being developed separately from current `master` on `sc-112938-baseline-fail-open`, with PostgreSQL fault-injection tests driving the lifecycle design before production changes. Thanks to the test and analysis here—they remain useful evidence for the replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
