mikebridge opened a new pull request, #41941: URL: https://github.com/apache/superset/pull/41941
### SUMMARY Makes optional entity-version baseline capture genuinely fail-open and all-or-nothing. A single SAVEPOINT now contains the synthetic baseline transaction row, parent shadow row, and every child shadow row. Child-handler failures propagate to that boundary so PostgreSQL rolls back the complete optional baseline unit before the error is logged, while the outer user save remains committable. This supersedes the parent-only approach in #41910, which was closed in favor of the broader parent/child atomicity work tracked by [sc-112938](https://app.shortcut.com/preset/story/112938). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; backend transaction-safety fix. ### TESTING INSTRUCTIONS Run the focused PostgreSQL failure cases: docker compose -f docker-compose-light.yml --profile test run --rm pytest-runner pytest -q tests/integration_tests/versioning/versions_api_tests.py -k "parent_baseline_sql_failure or child_baseline_sql_failure" Run the complete baseline/capture regression set: docker compose -f docker-compose-light.yml --profile test run --rm pytest-runner pytest -q tests/integration_tests/versioning/capture_disabled_tests.py tests/integration_tests/versioning/snapshot_projection_tests.py tests/integration_tests/versioning/versions_api_tests.py Observed locally: 2 fault-injection cases and 18 complete regression cases passed on PostgreSQL. Focused pre-commit passed, including mypy, Ruff, and Pylint. The all-files mypy hook reports five pre-existing errors outside this patch in docker/pythonpath_dev/superset_config_docker.py and tests/unit_tests/semantic_layers/mapper_test.py. ### ADDITIONAL INFORMATION - [x] Has associated issue: Shortcut sc-112938 - [x] Required feature flags: ENABLE_VERSIONING_CAPTURE - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
