Copilot commented on code in PR #41599:
URL: https://github.com/apache/superset/pull/41599#discussion_r3561826862
##########
superset/mcp_service/chart/tool/generate_chart.py:
##########
@@ -110,30 +110,44 @@ async def generate_chart( # noqa: C901
IMPORTANT: The 'chart_type' field in the config is a DISCRIMINATOR that
determines
which chart configuration schema to use. It MUST be included and MUST
match the
- other fields in your configuration:
+ other fields in your configuration. There are exactly 7 valid chart_type
values
+ — NOT 'line', 'bar', 'mixed_timeseries', etc. Those are 'kind' values
WITHIN
+ chart_type='xy' (see below), not chart_type values themselves:
Review Comment:
The docstring says chart_type is NOT "mixed_timeseries", but
mixed_timeseries is listed as a valid chart_type just below and is defined in
the ChartConfig discriminated union. This contradiction can mislead MCP
clients/LLMs and cause avoidable validation retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
