bito-code-review[bot] commented on PR #41923: URL: https://github.com/apache/superset/pull/41923#issuecomment-4939357581
<!-- Bito Reply --> The comment is accurate. Setting `chart_type` to `"unknown"` is indeed problematic because it discards the specific type information provided by the `ChartConfig` discriminator, which is essential for generating a correct and useful error payload. Since `ChartConfig` variants are designed to be self-describing via the `chart_type` field, using a generic "unknown" value undermines the schema's purpose and contradicts the intent of maintaining context for error handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
