bito-code-review[bot] commented on PR #41944:
URL: https://github.com/apache/superset/pull/41944#issuecomment-4940278145
<!-- Bito Reply -->
The change correctly implements the `--` separator in the
`prettier-frontend` hook within `.pre-commit-config.yaml`. By collecting the
filenames into an array and passing them after the `--` separator, the command
ensures that any files with names starting with hyphens are treated as
positional arguments rather than CLI flags, preventing potential execution
errors.
**.pre-commit-config.yaml**
```
entry: bash -c 'cd superset-frontend && files=(); for f in "$@"; do
files+=("${f#superset-frontend/}"); done; npx prettier --write "${files[@]}"' --
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]