rusackas commented on PR #40456: URL: https://github.com/apache/superset/pull/40456#issuecomment-4940426721
The `.copy()` fix itself is right. Joe's point is valid though that the test should use an actual sliced frame that fails without the `.copy()`, otherwise it doesn't really guard against someone removing it later. CI is also red at the moment. Let me know if the sliced-fixture setup is fiddly, or if I/we can help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
