codeant-ai-for-open-source[bot] commented on code in PR #38617:
URL: https://github.com/apache/superset/pull/38617#discussion_r3562892111
##########
tests/unit_tests/db_engine_specs/test_starrocks.py:
##########
@@ -230,8 +231,8 @@ def test_get_catalog_names(mocker: MockerFixture) -> None:
# StarRocks returns rows with keys: ['Catalog', 'Type', 'Comment']
mock_row_1 = mocker.MagicMock()
mock_row_1.keys.return_value = ["Catalog", "Type", "Comment"]
- mock_row_1.__getitem__ = (
- lambda self, key: "default_catalog" if key == "Catalog" else None
+ mock_row_1.__getitem__ = lambda self, key: (
+ "default_catalog" if key == "Catalog" else None
)
Review Comment:
**Suggestion:** Replace this untyped lambda assignment with a typed helper
callable (or otherwise provide explicit type annotations for its parameters and
return type) to satisfy the type-hint requirement. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new lambda is an untyped callable introduced in modified Python code.
Under the type-hint rule, newly added functions/callables that can be annotated
should include explicit parameter and return types, so this is a real violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=38060da6fea941c2b73b6bb8f9b6203c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=38060da6fea941c2b73b6bb8f9b6203c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/db_engine_specs/test_starrocks.py
**Line:** 234:236
**Comment:**
*Custom Rule: Replace this untyped lambda assignment with a typed
helper callable (or otherwise provide explicit type annotations for its
parameters and return type) to satisfy the type-hint requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38617&comment_hash=6d1ccd442c6f761233626209a738d62c066e6cdd695534a5432918eaf1c5a26e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38617&comment_hash=6d1ccd442c6f761233626209a738d62c066e6cdd695534a5432918eaf1c5a26e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
