codeant-ai-for-open-source[bot] commented on code in PR #41946:
URL: https://github.com/apache/superset/pull/41946#discussion_r3562898440
##########
tests/unit_tests/connectors/sqla/models_test.py:
##########
@@ -542,6 +542,72 @@ def
test_fetch_metadata_with_comment_field_existing_columns(
assert columns_by_name["name"].description == "Updated name description"
+def test_fetch_metadata_sets_expression_for_expanded_nested_columns(
+ mocker: MockerFixture,
+) -> None:
+ """
+ Test that fetch_metadata uses the `expression` hint provided by the db
engine
+ spec (e.g. Trino's expansion of nested `ROW` columns via `expand_rows`) to
set
+ the physical `TableColumn.expression`.
+
+ Without this, a nested column like `metadata.uuid` would have no
expression,
+ causing SQLAlchemy to render the whole dotted `column_name` as a single
quoted
+ identifier (`"metadata.uuid"`), which Trino rejects, instead of the correct
+ per-segment quoting (`"metadata"."uuid"`).
+
+ See: https://github.com/apache/superset/issues/27034
+ """
+ # Mock database
+ database = mocker.MagicMock()
+ database.get_metrics.return_value = []
+
+ # Mock db_engine_spec
+ mock_db_engine_spec = mocker.MagicMock()
+ mock_db_engine_spec.alter_new_orm_column = mocker.MagicMock()
+ database.db_engine_spec = mock_db_engine_spec
+
+ # Create table with a pre-existing (already synced) expanded column, to
also
+ # cover the "sync columns from source" (re-fetch) code path
+ table = SqlaTable(table_name="test_table_nested", database=database)
+ table.id = 1
+
+ existing_col = TableColumn(
+ column_name="metadata.uuid",
+ type="VARCHAR",
+ table=table,
+ expression="",
+ )
+ table.columns = [existing_col]
+
+ mock_columns = [
+ {
+ "column_name": "metadata",
+ "type": "ROW",
+ },
+ {
+ "column_name": "metadata.uuid",
+ "type": "VARCHAR",
+ "expression": '"metadata"."uuid"',
+ "query_as": '"metadata"."uuid" AS "metadata.uuid"',
+ },
+ ]
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
complex local variable so static type checking can validate the mocked metadata
structure. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The newly added test introduces a complex local variable holding a list of
metadata dictionaries, and it is not type-annotated. This matches the custom
rule requiring type hints for relevant Python variables that can be annotated.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f9bf3664b76e4292862dea6177a52ae9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f9bf3664b76e4292862dea6177a52ae9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/connectors/sqla/models_test.py
**Line:** 582:593
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
complex local variable so static type checking can validate the mocked metadata
structure.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41946&comment_hash=2ed119ebab33edb8e4cdd39ca9e6a6c1d023fa1894c27d5884189f0b9aea085f&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41946&comment_hash=2ed119ebab33edb8e4cdd39ca9e6a6c1d023fa1894c27d5884189f0b9aea085f&reaction=dislike'>๐</a>
##########
superset/connectors/sqla/models.py:
##########
@@ -2005,6 +2005,11 @@ def fetch_metadata(self) -> MetadataResult:
columns = []
for col in new_columns:
old_column = old_columns_by_name.pop(col["column_name"], None)
+ # Some engine specs (e.g. Trino, when expanding nested `ROW`
columns)
+ # provide an explicit SQL expression that must be used to select
the
+ # physical column, since simply quoting the dotted `column_name`
as a
+ # single identifier is not valid syntax for these nested fields.
+ expression = col.get("expression") or ""
Review Comment:
**Suggestion:** Add an explicit type annotation for the new local variable
to satisfy the type-hint requirement in modified code. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variable `expression` is introduced in modified Python code
without a type annotation, and its value is clearly a string (`str | None`
normalized to `str`), so it fits the rule requiring type hints on annotatable
variables.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e36e36b0154544b9b79e7b2201b88398&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e36e36b0154544b9b79e7b2201b88398&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/connectors/sqla/models.py
**Line:** 2012:2012
**Comment:**
*Custom Rule: Add an explicit type annotation for the new local
variable to satisfy the type-hint requirement in modified code.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41946&comment_hash=321d97b3ab1d2a3183357f1736f8c015d739861f9e269791d508002796598872&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41946&comment_hash=321d97b3ab1d2a3183357f1736f8c015d739861f9e269791d508002796598872&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
