bito-code-review[bot] commented on code in PR #41950:
URL: https://github.com/apache/superset/pull/41950#discussion_r3563532542
##########
pyproject.toml:
##########
@@ -161,7 +161,7 @@ fastmcp = [
# heuristic that under-counts JSON-heavy MCP responses.
"tiktoken>=0.13.0,<1.0",
]
-firebird = ["sqlalchemy-firebird>=0.7.0, <2.2"]
+firebird = ["sqlalchemy-firebird>=0.8.0, <2.2"]
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Documentation version mismatch</b></div>
<div id="fix">
`pyproject.toml` now requires `sqlalchemy-firebird>=0.8.0,<2.2` (line 164),
but `superset/db_engine_specs/firebird.py:42` and
`docs/user_docs_versioned_docs/version-6.1.0/databases/supported/firebird.mdx:29`
still hardcode `>=0.7.0,<0.8`. These metadata values must be updated to match
the new dependency constraint, otherwise the documented version requirements
will contradict the actual package requirements.
</div>
</div>
<small><i>Code Review Run #56b65c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
