bito-code-review[bot] commented on PR #41935:
URL: https://github.com/apache/superset/pull/41935#issuecomment-4947906258
<!-- Bito Reply -->
The flagged issue is correct. The variable `pkg_resources_filters` is a list
of filter tuples, which can be explicitly annotated as `list[Any]` or
`list[tuple[Any, ...]]` to improve type safety and readability.
To resolve this, you can update the variable declaration in
`tests/unit_tests/mcp_service/test_mcp_server.py` as follows:
```python
pkg_resources_filters: list[Any] = [
f
for f in warnings.filters
if f[0] == "ignore"
and isinstance(f[1], re.Pattern)
and f[1].pattern == r"pkg_resources is deprecated as an API"
]
```
I have checked the other comments on this PR, and there are no other pending
review comments to address. Would you like me to perform any other tasks?
**tests/unit_tests/mcp_service/test_mcp_server.py**
```
pkg_resources_filters: list[Any] = [
f
for f in warnings.filters
if f[0] == "ignore"
and isinstance(f[1], re.Pattern)
and f[1].pattern == r"pkg_resources is deprecated as an API"
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
