rusackas commented on code in PR #40180:
URL: https://github.com/apache/superset/pull/40180#discussion_r3564748809
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -1843,6 +1843,54 @@ describe('plugin-chart-table', () => {
expect(secondCallArg.extraFormData.filters).toEqual([]);
});
+ test('clicking a temporal numeric-string cell emits numeric cross-filter
values', () => {
+ const setDataMask = jest.fn();
+ const timestamp = 1777248000000;
+ const props = transformProps({
+ ...testData.basic,
+ hooks: { setDataMask },
+ emitCrossFilters: true,
+ });
+
+ render(
+ <ProviderWrapper>
+ <TableChart
+ {...props}
+ data={[{ install_date: String(timestamp) }]}
+ columns={[
+ {
+ key: 'install_date',
+ label: 'install_date',
+ dataType: GenericDataType.Temporal,
+ isNumeric: false,
+ isMetric: false,
+ isPercentMetric: false,
+ formatter: String,
+ config: {},
+ },
+ ]}
+ emitCrossFilters
+ setDataMask={setDataMask}
+ sticky={false}
+ />
+ </ProviderWrapper>,
+ );
+
+ fireEvent.click(screen.getByText(String(timestamp)));
+
+ const crossFilterCall = setDataMask.mock.calls.find(
+ (call: any[]) => call[0]?.filterState?.filters,
+ );
Review Comment:
Already sorted. That callback is typed via `jest.fn<void, [DataMask]>()`
now, so there's no `any` on it. The remaining `(call: any[])` in the file
predate this PR.
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -1843,6 +1843,54 @@ describe('plugin-chart-table', () => {
expect(secondCallArg.extraFormData.filters).toEqual([]);
});
+ test('clicking a temporal numeric-string cell emits numeric cross-filter
values', () => {
+ const setDataMask = jest.fn();
+ const timestamp = 1777248000000;
+ const props = transformProps({
+ ...testData.basic,
+ hooks: { setDataMask },
+ emitCrossFilters: true,
+ });
+
+ render(
+ <ProviderWrapper>
+ <TableChart
+ {...props}
+ data={[{ install_date: String(timestamp) }]}
+ columns={[
+ {
+ key: 'install_date',
+ label: 'install_date',
+ dataType: GenericDataType.Temporal,
+ isNumeric: false,
+ isMetric: false,
+ isPercentMetric: false,
+ formatter: String,
+ config: {},
+ },
+ ]}
+ emitCrossFilters
+ setDataMask={setDataMask}
+ sticky={false}
+ />
+ </ProviderWrapper>,
+ );
+
+ fireEvent.click(screen.getByText(String(timestamp)));
+
+ const crossFilterCall = setDataMask.mock.calls.find(
+ (call: any[]) => call[0]?.filterState?.filters,
+ );
Review Comment:
Test callback verification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
