bito-code-review[bot] commented on PR #41964:
URL: https://github.com/apache/superset/pull/41964#issuecomment-4948250703
<!-- Bito Reply -->
The flagged issue is correct. Adding an explicit type annotation to the
local variable `database` improves code readability and maintainability,
aligning with standard Python practices.
To resolve this, update the variable declaration in
`tests/unit_tests/connectors/sqla/models_test.py` as follows:
```python
Database.metadata.create_all(session.bind)
database: Database = Database(database_name="my_db",
sqlalchemy_uri="sqlite://")
# A column the user mistakenly marks as temporal ("Is Temporal") and
then picks
```
There are no other comments on this PR to address. Would you like me to
check for any other potential improvements in this file?
**tests/unit_tests/connectors/sqla/models_test.py**
```
Database.metadata.create_all(session.bind)
database: Database = Database(database_name="my_db",
sqlalchemy_uri="sqlite://")
# A column the user mistakenly marks as temporal ("Is Temporal") and
then picks
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
