codeant-ai-for-open-source[bot] commented on code in PR #41968:
URL: https://github.com/apache/superset/pull/41968#discussion_r3564778470
##########
tests/integration_tests/security/row_level_security_tests.py:
##########
@@ -469,6 +469,58 @@ def
test_rls_tables_related_api_with_filter_matching_birth(self):
assert all("birth" in table_name.lower() for table_name in
received_tables)
assert len(result) >= 1 # At least birth_names should be returned
+ @pytest.mark.usefixtures("load_birth_names_data")
+ def test_rls_tables_related_api_returns_all_masked_matches(self):
Review Comment:
**Suggestion:** Add a return type annotation to the new test method so its
signature is fully typed (for example, annotate it as returning `None`).
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new test method is added in the PR and lacks an explicit return type
annotation. Under the Python type-hints rule, test methods should be annotated
(for example, `-> None`), so this is a real violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1390a7345b0c47908cff1239f7175d23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1390a7345b0c47908cff1239f7175d23&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/security/row_level_security_tests.py
**Line:** 473:473
**Comment:**
*Custom Rule: Add a return type annotation to the new test method so
its signature is fully typed (for example, annotate it as returning `None`).
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41968&comment_hash=1dcb17a8d4a568925bc5aef3c0c77bfae57c576a3c9bf2d421afb17666a0dcff&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41968&comment_hash=1dcb17a8d4a568925bc5aef3c0c77bfae57c576a3c9bf2d421afb17666a0dcff&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
